[build] Add /Zc:__cplusplus switch to fix __cplusplus on MSVC#6422
Open
AlrIsmail wants to merge 1 commit intoPointCloudLibrary:masterfrom
Open
[build] Add /Zc:__cplusplus switch to fix __cplusplus on MSVC#6422AlrIsmail wants to merge 1 commit intoPointCloudLibrary:masterfrom
AlrIsmail wants to merge 1 commit intoPointCloudLibrary:masterfrom
Conversation
AlrIsmail
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3494.
This PR adds the
/Zc:__cpluspluscompiler flag when building with MSVC 15.7 or newer to ensure the__cplusplusmacro correctly reports the C++ standard version.Key Changes:
/Zc:__cplusplusto globalCMAKE_CXX_FLAGSfor MSVC 15.7+.PCLCONFIG_COMPILE_OPTIONStopcl_pclconfig.cmakefor storing/exporting compile options.PCLConfig.cmake.inso downstream projects inherit the flag.Verification: Verified CMake logic via mock tests for older and newer MSVC versions, ensuring alignment with existing PCL build patterns.